Skip to content

Remove dead code. #3219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
traefiker merged 1 commit into from
Apr 23, 2018
Merged

Remove dead code. #3219

traefiker merged 1 commit into from
Apr 23, 2018

Conversation

@ldez
Copy link
Contributor

@ldez ldez commented Apr 22, 2018

What does this PR do?

  • remove dead code.
  • manage error.

Motivation

Have a good code.

@ldez ldez requested a review from a team as a code owner April 22, 2018 00:38
@traefiker traefiker added this to the 1.6 milestone Apr 22, 2018
juliens
juliens approved these changes Apr 22, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nmengin
nmengin approved these changes Apr 23, 2018
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes Apr 23, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit d8e2d46 into traefik:v1.6 Apr 23, 2018
@ldez ldez deleted the fix/code-review branch April 23, 2018 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliens juliens juliens approved these changes

@mmatur mmatur mmatur approved these changes

@nmengin nmengin nmengin approved these changes

Assignees

No one assigned

Labels

area/infrastructure size/L

Projects

None yet

Milestone

1.6

Development

Successfully merging this pull request may close these issues.

5 participants

@ldez @juliens @mmatur @nmengin @traefiker