Skip to content

Adding grafana dashboards based on prometheus metrics #3393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
traefiker merged 2 commits into from
Jun 6, 2018
Merged

Adding grafana dashboards based on prometheus metrics #3393

traefiker merged 2 commits into from
Jun 6, 2018

Conversation

@deimosfr
Copy link
Contributor

@deimosfr deimosfr commented May 25, 2018

Adding grafana dashboards based on promtheus metrics for standard and k8s config

@ldez ldez changed the title Adding grafana dashboards based on promtheus metrics Adding grafana dashboards based on prometheus metrics May 26, 2018
mmatur
mmatur requested changes May 30, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome dashboards!! 👏
Few comments

contrib/grafana/traefik-kubernetes.json Outdated
Copy link
Member

@mmatur mmatur May 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please replace "datasource": "prometheus" by "datasource": "${DS_PROMETHEUS}"

contrib/grafana/traefik-kubernetes.json Outdated
Copy link
Member

@mmatur mmatur May 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please replace "datasource": "prometheus" by "datasource": "${DS_PROMETHEUS}"

contrib/grafana/traefik-kubernetes.json Outdated
Copy link
Member

@mmatur mmatur May 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please replace "datasource": "prometheus" by "datasource": "${DS_PROMETHEUS}"

contrib/grafana/traefik-kubernetes.json Outdated
Copy link
Member

@mmatur mmatur May 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please replace "datasource": "prometheus" by "datasource": "${DS_PROMETHEUS}"

contrib/grafana/traefik.json Outdated
Copy link
Member

@mmatur mmatur May 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please replace "datasource": "prometheus" by "datasource": "${DS_PROMETHEUS}"

contrib/grafana/traefik.json Outdated
Copy link
Member

@mmatur mmatur May 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please replace "datasource": "prometheus" by "datasource": "${DS_PROMETHEUS}"

contrib/grafana/traefik-kubernetes.json Outdated
Copy link
Member

@mmatur mmatur May 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please replace 000000113 by TraefikKubernetes

contrib/grafana/traefik-kubernetes.json Outdated
Copy link
Member

@mmatur mmatur May 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please set version to 1

contrib/grafana/traefik.json Outdated
Copy link
Member

@mmatur mmatur May 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please replace 000000113 by Traefik

contrib/grafana/traefik.json Outdated
Copy link
Member

@mmatur mmatur May 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please set version to 1

@deimosfr
Copy link
Contributor Author

deimosfr commented Jun 6, 2018

modifcations done

@mmatur mmatur added this to the 1.7 milestone Jun 6, 2018
mmatur
mmatur approved these changes Jun 6, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SantoDE
SantoDE approved these changes Jun 6, 2018
View reviewed changes
Copy link
Collaborator

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👼 Thanks!

ldez
ldez approved these changes Jun 6, 2018
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 2c47691 into traefik:master Jun 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SantoDE SantoDE SantoDE approved these changes

@mmatur mmatur mmatur approved these changes

+1 more reviewer

@ldez ldez ldez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/documentation area/infrastructure kind/enhancement a new or improved feature. size/L

Projects

None yet

Milestone

1.7

Development

Successfully merging this pull request may close these issues.

5 participants

@deimosfr @SantoDE @mmatur @ldez @traefiker