Skip to content

Use net.JoinHostPort for servers URL #3484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
traefiker merged 1 commit into from
Jun 13, 2018
Merged

Use net.JoinHostPort for servers URL #3484

traefiker merged 1 commit into from
Jun 13, 2018

Conversation

@ldez
Copy link
Contributor

@ldez ldez commented Jun 12, 2018

What does this PR do?

Use net.JoinHostPort for servers URL.

Motivation

Support IPv6

@ldez ldez requested review from a team as code owners June 12, 2018 23:29
@traefiker traefiker added this to the 1.6 milestone Jun 12, 2018
dtomcej
dtomcej approved these changes Jun 13, 2018
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean 😄
LGTM
:shipit:

vdemeester
vdemeester approved these changes Jun 13, 2018
View reviewed changes
Copy link
Contributor

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦍

juliens
juliens approved these changes Jun 13, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit b59276f into traefik:v1.6 Jun 13, 2018
@ldez ldez deleted the fix/ipv6 branch June 13, 2018 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliens juliens juliens approved these changes

@traefiker traefiker traefiker approved these changes

+2 more reviewers

@vdemeester vdemeester vdemeester approved these changes

@dtomcej dtomcej dtomcej approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/provider/docker area/provider/ecs area/provider/marathon area/provider/mesos area/provider/rancher kind/bug/fix a bug fix size/S

Projects

None yet

Milestone

1.6

Development

Successfully merging this pull request may close these issues.

5 participants

@ldez @vdemeester @juliens @dtomcej @traefiker