Skip to content

Remove etcd v2 #3739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
traefiker merged 6 commits into from
Aug 7, 2018
Merged

Remove etcd v2 #3739

traefiker merged 6 commits into from
Aug 7, 2018

Conversation

@geraldcroes
Copy link
Contributor

@geraldcroes geraldcroes commented Aug 6, 2018

What does this PR do?

Removes the ETCD v2 support

Motivation

Removes deprecated elements

More

  • Added/updated tests
  • Added/updated documentation

@ldez ldez added this to the next milestone Aug 6, 2018
nmengin
nmengin approved these changes Aug 7, 2018
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@geraldcroes
Copy link
Contributor Author

geraldcroes commented Aug 7, 2018

Thx @nmengin for your help!

ldez
ldez approved these changes Aug 7, 2018
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dtomcej
dtomcej approved these changes Aug 7, 2018
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

@traefiker traefiker merged commit 1ec4e03 into traefik:master Aug 7, 2018
@ldez ldez deleted the remove-etcd-v2 branch August 7, 2018 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nmengin nmengin nmengin approved these changes

+2 more reviewers

@ldez ldez ldez approved these changes

@dtomcej dtomcej dtomcej approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/provider/etcd kind/enhancement a new or improved feature. size/L

Projects

None yet

Milestone

2.0

Development

Successfully merging this pull request may close these issues.

5 participants

@geraldcroes @ldez @nmengin @dtomcej @traefiker