Improve the wording in the documentation for Docker and fix title for Docker User Guide #3797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… page, about the 'domain' directive Signed-off-by: Damien DUPORTAL <damien.duportal@gmail.com>
…ocker Signed-off-by: Damien DUPORTAL <damien.duportal@gmail.com>
This was referenced Aug 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This Pull Request introduce 2 changes:
Improving the wording in the documentation for the Docker configuration page,
about the
domaindirectiveFixing the title of the documentation's user guide about Let's Encrypt & Docker
Motivation
I was stuck on a basic use case: "1 container behind 1 traefik". Being too quick, I directly read the Docker's Configuration page, where it was saying "docker.domain: set the domain to use". This simple rewording put an attention point for the newcomer, so they will search for the rule, and won't be stuck on this. Having checked this with @nmengin confirmed me it could be a good idea to reword (Hence the rewording I propose is not an absolute one :) )
More
Additional Notes