Allow Træfik to know if a Host rule is malformed #3848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmengin
added
status/2-needs-review
kind/bug/fix
ldez
suggested changes
Sep 4, 2018
rules/rules.go
Outdated
Contributor
There was a problem hiding this comment.
Could you rewrite this section like that:
var cleanDomains []string
for _, domain := range domains {
canonicalDomain := types.CanonicalDomain(domain)
if len(canonicalDomain) > 0 {
cleanDomains = append(cleanDomains, canonicalDomain)
}
}
return isHostRule, cleanDomains, nil
traefiker
force-pushed
the
hotfix/manage-malformed-host-rule
branch
from
80a436d to
6ec6251
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR allows users to know if a
Hostrule is malformed by returning aboolto prevent that aHostRule has been detected.Thus if a
Hostrule is detected and no domain are returned, a specific error message can be created.Motivation
User reported that ACME has not created domains with the error message
Error getting valid domain: unable to generate a certificate when no domain is given..The error has came from his
Hostrule but the message has not indicated it.The PR improves the error management.
More