Removed non-applicable default tests and fixed custom tests#3908
Merged
traefiker merged 1 commit intotraefik:v1.7from Sep 21, 2018
Merged
Removed non-applicable default tests and fixed custom tests#3908traefiker merged 1 commit intotraefik:v1.7from
traefiker merged 1 commit intotraefik:v1.7from
Conversation
i78
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The existing tests in the webui appear to be generated automatically when the project was created, but unfortunately they do not apply on the current project structure anymore, so they break. This PR removes tests which do not make sense anymore and fixes the ones which are still applicable.
Motivation
Breaking tests can be very disturbing when adding own features and could also affect the impression. Also, they might lead to excluding angular tests from the CI jobs.
More
Additional Notes
n/a