Skip to content

Conversation

@emilevauge
Copy link
Member

What does this PR do?

This PR adds a notice to warn users that a major overhaul is currently occurring on master branch.

Motivation

Be transparent.

@ldez ldez added this to the next milestone Oct 1, 2018
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

README.md Outdated

---

:construction: As stated in [our latest 1.7 release note](https://blog.containo.us/traefik-1-7-yet-another-slice-of-awesomeness-2a9c99737889#782d), a major overhaul is currently occuring on the [master](https://github.com/containous/traefik/tree/master) branch. It will remain in constant evolution and prone to change with little notice.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"the 1.7 release note"
"is occurring" (two r and currently not necessary) - or replace by is in progress.
It: unclear antecedent (major overhaul or the branch). Maybe "This branch will ..."
Maybe add what it means for the user -> ... so use it for test purposes only.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also rather use "significant update" instead of "major overhaul"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@emilevauge emilevauge force-pushed the emilevauge-master-overhaul-notice branch from 97901fe to 15fa6ce Compare October 1, 2018 13:46
Copy link
Contributor

@geraldcroes geraldcroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 5eae95e into master Oct 1, 2018
@ldez ldez deleted the emilevauge-master-overhaul-notice branch October 1, 2018 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants