-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Add master overhaul notice #3961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ldez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
juliens
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jbdoumenjou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
README.md
Outdated
|
|
||
| --- | ||
|
|
||
| :construction: As stated in [our latest 1.7 release note](https://blog.containo.us/traefik-1-7-yet-another-slice-of-awesomeness-2a9c99737889#782d), a major overhaul is currently occuring on the [master](https://github.com/containous/traefik/tree/master) branch. It will remain in constant evolution and prone to change with little notice. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"the 1.7 release note"
"is occurring" (two r and currently not necessary) - or replace by is in progress.
It: unclear antecedent (major overhaul or the branch). Maybe "This branch will ..."
Maybe add what it means for the user -> ... so use it for test purposes only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd also rather use "significant update" instead of "major overhaul"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
97901fe to
15fa6ce
Compare
geraldcroes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What does this PR do?
This PR adds a notice to warn users that a major overhaul is currently occurring on master branch.
Motivation
Be transparent.