Skip to content

Comments

Provider docker shutdown problem#4122

Merged
traefiker merged 2 commits intotraefik:v1.7from
juliens:fix-docker-shutdown
Oct 29, 2018
Merged

Provider docker shutdown problem#4122
traefiker merged 2 commits intotraefik:v1.7from
juliens:fix-docker-shutdown

Conversation

@juliens
Copy link
Member

@juliens juliens commented Oct 27, 2018

What does this PR do?

Use GoCtx in provider docker

Motivation

Handle provider docker shutdown correctly when traefik is shutting down

Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@geraldcroes geraldcroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker force-pushed the fix-docker-shutdown branch from f52a4f9 to 3828ccb Compare October 29, 2018 14:00
@traefiker traefiker merged commit 7eeecd2 into traefik:v1.7 Oct 29, 2018
@ldez ldez added the kind/bug/fix a bug fix label Oct 30, 2018
@juliens juliens deleted the fix-docker-shutdown branch September 6, 2019 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants