Include an explicit list of kubernetes protocol annotations in docs.#4170
Merged
traefiker merged 3 commits intotraefik:v1.7from Nov 15, 2018
shanna:kubernetes-protocol-annotation
Merged
Include an explicit list of kubernetes protocol annotations in docs.#4170traefiker merged 3 commits intotraefik:v1.7from shanna:kubernetes-protocol-annotation
traefiker merged 3 commits intotraefik:v1.7from
shanna:kubernetes-protocol-annotation
Conversation
SantoDE
approved these changes
Nov 8, 2018
Collaborator
SantoDE
left a comment
SantoDE
left a comment
There was a problem hiding this comment.
LGTM 👼
To your note: Yeah, I think we can deprecate it imho. Let's see what the others have to add on that :)
dtomcej
suggested changes
Nov 8, 2018
traefiker
added
bot/merge-retry-1
status/4-merge-in-progress
and removed
bot/merge-retry-1
labels
Co-Authored-By: shanna <shane.hanna@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Includes an explicit list of valid protocols in kubernetes backend documentation.
Motivation
The idea of using port 443 or the special ingress spec port name seemed like something that will trip up other developers on my team. I saw the
ingress.kubernetes.io/protocolannotation in the documentation but couldn't find the valid values. Bothhttp2andh2as someone suggested on slack both produced errors in the log so I was forced to search the source code.More
Additional Notes
Can the special port
443andhttpsprefix logic be deprecated and eventually removed now there is an explicit way to override the default protocol in the kubernetes back end?