Forward all header values from forward auth response #4515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbdoumenjou
added
status/1-needs-design-review
and removed
status/0-needs-triage
labels
Contributor
|
Thank you for this PR. Sorry for the late answer. Could you rebase this pull request on v1.7 branch? |
ldez
added
contributor/waiting-for-corrections
status/2-needs-review
kind/bug/fix
ctas582
force-pushed
the
fwd-all-header-values
branch
from
3b2acec to
3dcfd91
Compare
Contributor
Author
|
Rebased on v1.7 branch 👍 |
ldez
force-pushed
the
fwd-all-header-values
branch
from
b1bc9a7 to
7f3eb32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Forwards all header values from the forward authentication response to the destination.
Motivation
I'm using Traefik as an authenticating proxy in front of the Kubernetes API server. Traefik is configured to use forward authentication, which returns multiple "X-Remote-Group" headers. Currently, however, only the first of these headers is forwarded on to the destination. The Kubernetes API server requires a separate header to be sent for each group.
More
Additional Notes