Skip to content

Migrate to go-acme/lego.#4577

Merged
traefiker merged 1 commit intotraefik:v1.7from
ldez:chore/migrate-go-acme
Mar 12, 2019
Merged

Migrate to go-acme/lego.#4577
traefiker merged 1 commit intotraefik:v1.7from
ldez:chore/migrate-go-acme

Conversation

@ldez
Copy link
Contributor

@ldez ldez commented Mar 11, 2019

What does this PR do?

Migrate to go-acme.

Fixed:

  • OVH: Refresh zone after deleting challenge record
  • hostingde: fix client fails if customer has no access to dns-groups
  • vscale: getting sub-domain
  • selectel: getting sub-domain
  • vscale: fix TXT records clean up
  • selectel: fix TXT records clean up

Motivation

Applies some bug fixes.

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

  • Add DNS Provider for ClouDNS.net
  • Add DNS Provider for Oracle Cloud

@ldez ldez added status/2-needs-review area/acme kind/bug/fix a bug fix bot/light-review decreases the number of required LGTM from 3 to 1. labels Mar 11, 2019
@ldez ldez added this to the 1.7 milestone Mar 11, 2019
@ldez ldez force-pushed the chore/migrate-go-acme branch from 41e9512 to 7a772cd Compare March 11, 2019 21:19
@ldez ldez force-pushed the chore/migrate-go-acme branch from 7a772cd to dfa4032 Compare March 11, 2019 21:23
@ldez ldez changed the title Migrate to go-acme. Migrate to go-acme/lego. Mar 11, 2019
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏 👏 @ldez

@EugenMayer
Copy link
Contributor

Is that a successor of github.com/xenolf/lego or a new implementation? I just wonder, there are no credits, its not a fork but it is still the same name.

Does this mean that the ACME implementation is a new one (entirely) ? Thanks

@ldez
Copy link
Contributor Author

ldez commented Apr 4, 2019

The project migrated from a user account (xenolf) to an organization (go-acme).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants