Skip to content

Conversation

@ldez
Copy link
Contributor

@ldez ldez commented May 15, 2019

What does this PR do?

Give more context when an error occurs.

Motivation

Enhance KV logs.

More

  • Added/updated tests
  • Added/updated documentation

@salzig
Copy link

salzig commented May 15, 2019

I would say this is not only an enhancement, but also a bug fix (Line 804)

@ldez
Copy link
Contributor Author

ldez commented May 15, 2019

The change to L804 is related to the change L642, it was not needed before.

Copy link
Collaborator

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants