-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Rework loadbalancer support #4933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbdoumenjou
requested changes
Jun 4, 2019
Co-Authored-By: Jean-Baptiste Doumenjou <jb.doumenjou@gmail.com>
jbdoumenjou
approved these changes
Jun 5, 2019
Collaborator
jbdoumenjou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dtomcej
approved these changes
Jun 5, 2019
Contributor
dtomcej
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
![]()
ldez
approved these changes
Jun 5, 2019
Contributor
ldez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
2 tasks
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove wrr and drr LoadBalancers to prepare configuration to accept new load balancers.
Motivation
We plan on adding more load balancer strategies later on. In order to do that we'll need some sort of generic method that may turn out to be incompatible with the current way wrr and drr are implemented. Therefore, if we do not want to break configuration later on when we add these new strategies, we have to remove wrr and drr now.
More