Skip to content

Conversation

@juliens
Copy link
Member

@juliens juliens commented Jun 4, 2019

What does this PR do?

Remove wrr and drr LoadBalancers to prepare configuration to accept new load balancers.

Motivation

We plan on adding more load balancer strategies later on. In order to do that we'll need some sort of generic method that may turn out to be incompatible with the current way wrr and drr are implemented. Therefore, if we do not want to break configuration later on when we add these new strategies, we have to remove wrr and drr now.

More

  • Added/updated tests
  • Added/updated documentation

Co-Authored-By: Jean-Baptiste Doumenjou <jb.doumenjou@gmail.com>
Copy link
Collaborator

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez mentioned this pull request Jun 15, 2019
2 tasks
@ldez ldez changed the title rework loadbalancer support Rework loadbalancer support Jun 17, 2019
@ldez ldez deleted the remove-wrrdrr branch August 25, 2019 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants