Change the provider separator from . to @ #4982
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
kind/enhancement
mpl
approved these changes
Jun 19, 2019
Collaborator
mpl
left a comment
mpl
left a comment
There was a problem hiding this comment.
LGTM,
but I haven't checked that all cases were covered, only that the covered cases looked alright.
ldez
force-pushed
the
feature/crossprovider-separator
branch
from
6d63188 to
bd8b4f7
Compare
traefiker
force-pushed
the
feature/crossprovider-separator
branch
from
bd8b4f7 to
53ad712
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
use
@as the separator between provider name and reference name (instead of.)Motivation
Have less unambiguous separator.
More