Skip to content

Conversation

@ldez
Copy link
Contributor

@ldez ldez commented Jun 25, 2019

What does this PR do?

Adds support for YAML for the dynamic configuration.

In #4935 we added the support for YAML support for the static configuration.

Motivation

Fixes #2999

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

Prepare your bracket, prepare your mind to indentation issues, case sensitivity issues: so prepare your body for the chaos of YAML format.

It's a sad day for me: I made the YAML support 😢.

@emilevauge
Copy link
Member

emilevauge commented Jun 25, 2019

An overview of our brand new support forum starting tomorrow 😁:

crowd

Jokes aside, great job 👏

@ldez ldez force-pushed the feature/dyn-conf-file branch from 255bbbb to fe22fbd Compare June 25, 2019 22:38
@dtomcej
Copy link
Contributor

dtomcej commented Jun 25, 2019

giphy

@geraldcroes
Copy link
Contributor

dance

Copy link
Collaborator

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great job! 🕺

Copy link
Collaborator

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@geraldcroes geraldcroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ LGTM ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants