Skip to content

Fixed doc link for AlibabaCloud #5109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
traefiker merged 1 commit into from
Jul 16, 2019
Merged

Fixed doc link for AlibabaCloud #5109

traefiker merged 1 commit into from
Jul 16, 2019

Conversation

@ddymko
Copy link
Contributor

@ddymko ddymko commented Jul 16, 2019

What does this PR do?

The Alibabacloud link on acme.md was pointing to vultr.com

Motivation

Wanted to fix it so the link would point to the proper cloud provider

More

  • Added/updated tests
  • Added/updated documentation

@ldez ldez force-pushed the doc-acme-alidns branch from 11ea481 to 6ac4253 Compare July 16, 2019 11:16
@ddymko ddymko requested review from a team as code owners July 16, 2019 11:16
@ldez ldez changed the base branch from master to v1.7 July 16, 2019 11:16
@ldez ldez removed request for a team July 16, 2019 11:16
@ldez ldez added this to the 1.7 milestone Jul 16, 2019
ldez
ldez approved these changes Jul 16, 2019
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

dduportal
dduportal approved these changes Jul 16, 2019
View reviewed changes
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks ! 📖

@ldez ldez force-pushed the doc-acme-alidns branch from 6ac4253 to 4cbfdf2 Compare July 16, 2019 13:58
@traefiker traefiker merged commit 7db4196 into traefik:v1.7 Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@timoreimann timoreimann timoreimann approved these changes

@dduportal dduportal dduportal approved these changes

@ldez ldez ldez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/acme area/documentation kind/bug/fix a bug fix size/S

Projects

None yet

Milestone

1.7

Development

Successfully merging this pull request may close these issues.

5 participants

@ddymko @timoreimann @dduportal @ldez @traefiker