Replace ambiguous cli help message wording #5233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
area/documentation
kind/enhancement
mpl
requested changes
Sep 18, 2019
cmd/healthcheck/healthcheck.go
Outdated
Collaborator
There was a problem hiding this comment.
Suggested change
| Description: `Calls Traefik /ping to check the health of Traefik (the endpoint must be enabled).`, | |
| Description: `Calls Traefik /ping endpoint (disabled by default) to check the health of Traefik.`, |
mpl
approved these changes
Oct 7, 2019
traefiker
added
bot/merge-retry-1
status/4-merge-in-progress
and removed
bot/merge-retry-1
labels
The term `API` could be mistaken with the Traefik web interface exposing the configuration of router, services and middlewares (As in https://docs.traefik.io/v2.0/operations/api/). This pr replaces this term with the word `endpoint`, which is also used in the documentation for this feature (https://docs.traefik.io/v2.0/operations/ping/). Fixes: #5226
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The term
APIcould be mistaken with the Traefik web interfaceexposing the configuration of router, services and middlewares
(As in https://docs.traefik.io/v2.0/operations/api/).
This pr replaces this term with the word
endpoint, which is alsoused in the documentation for this feature
(https://docs.traefik.io/v2.0/operations/ping/).
Fixes: #5226