Fix wrong handling of insecure tls auth forward ingress annotation #5319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
suggested changes
Sep 7, 2019
ldez
changed the title
…il, it's not the expected behavior. So you must do that. @idez
Author
|
@ldez done, but personally I would do it in slightly other way. |
ldez
added
kind/bug/fix
Contributor
|
Please don't merge, our bot manage the rebase. |
Author
|
Ok, sorry
|
|
Wow. I spent all day yesterday head-desking because of this. Glad to see someone is working on a fix asap. |
|
Any idea when 1.7.15 will be released? |
2 tasks
Contributor
|
Hi @woodcockjosh Traefik |
|
@dduportal thanks. I actually upgraded to 2.0 since I couldn't get 1.7.16 working |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes wrong handling of the insecure tls auth forward Ingress annotation, closing the #4836
Motivation
Lack of "default" router configuration in traefik v2
More
Additional Notes
It is hotfix and should be merged asap (or faster)