k8s ErrorPage middleware now uses k8s service #5339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliens
added
kind/enhancement
juliens
force-pushed
the
errorpage-k8s
branch
from
8e60350 to
7d030b4
Compare
dtomcej
reviewed
Sep 10, 2019
Contributor
dtomcej
left a comment
dtomcej
left a comment
There was a problem hiding this comment.
Just a few small comments
traefiker
force-pushed
the
errorpage-k8s
branch
from
bc13592 to
67b0e21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR changes the definition of error page middleware in k8s.
Motivation
Be able to ref the service in the error page middleware in k8s.
More