Skip to content

Add note clarifying client certificate header#5362

Merged
traefiker merged 4 commits intotraefik:v1.7from
bradjones1:patch-2
Sep 19, 2019
Merged

Add note clarifying client certificate header#5362
traefiker merged 4 commits intotraefik:v1.7from
bradjones1:patch-2

Conversation

@bradjones1
Copy link
Contributor

What does this PR do?

Adds note clarifying client certificate header is not passed through unless it is from a CA specified on the EntryPoint.

Motivation

This section suggests the client certificate sent is added to the header if the configuration is set on the Ingress; this alone is not sufficient (it must also pass validation at the EntryPoint, which requires separate config.)

More

  • Added/updated tests
  • Added/updated documentation

@bradjones1
Copy link
Contributor Author

Refs #4493

Copy link
Collaborator

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ldez ldez added the kind/enhancement a new or improved feature. label Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants