Skip to content

Conversation

@zaverden
Copy link
Contributor

@zaverden zaverden commented Sep 13, 2019

What does this PR do?

It fixes "A Service with One Server" .yaml example

Motivation

Example yaml has wrong format which leads to error:
level=error msg="Cannot start the provider *file.Provider: yaml: unmarshal errors:\n line 10: cannot unmarshal !!map into []dynamic.Server"

More

  • Added/updated tests (not needed)
  • Added/updated documentation

Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately you have change the wrong snippet of code.

You should update the line 108

@ldez ldez changed the title [doc] fix A Service with One Server .yaml example fix a service with one server .yaml example Sep 13, 2019
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@ldez ldez added the kind/bug/fix a bug fix label Sep 13, 2019
Copy link
Collaborator

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zaverden and others added 2 commits September 13, 2019 09:24
level=error msg="Cannot start the provider *file.Provider: yaml: unmarshal errors:\n  line 10: cannot unmarshal !!map into []dynamic.Server"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants