Skip to content

Conversation

@ldez
Copy link
Contributor

@ldez ldez commented Sep 20, 2019

What does this PR do?

Improve documentation for the TLS section of the provider connection.

Motivation

Remove TODO

More

  • Added/updated tests
  • Added/updated documentation

Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, cool update!

Feedback: A few typos and some proposal for improving reader experience.

Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 📖

Copy link
Collaborator

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ldez and others added 2 commits September 20, 2019 14:52
@traefiker traefiker merged commit f929346 into traefik:v2.0 Sep 20, 2019
@ldez ldez deleted the fix/doc-todo branch September 20, 2019 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants