Skip to content

Conversation

@EugenMayer
Copy link
Contributor

@EugenMayer EugenMayer commented Dec 8, 2019

Right now it makes it harder for people not using the insecure mode to recognize that the dashboard can only be reached using the trailing slash only since it is at the bottom of the page to the "insecure" chapter ( which those people will most probably skip ) -

I assume the trailing slash is somewhat surprising, it might be helpful to make the fact more prominent

More

  • Added/updated documentation

Additional Notes

Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpl mpl changed the title Make trailing slash more promoninet for the "secure dashboard setup" too Make trailing slash more prominent for the "secure dashboard setup" too Dec 9, 2019
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👼

EugenMayer and others added 2 commits December 9, 2019 11:24
Right now it makes it harder for people not using the `insecure` mode to recognize that the dashboard can only be reached using the trailing slash only since it is at the bottom of the page to the "insecure" chapter ( which those people will most probably skip ) -

I assume the trailing slash is somewhat suprising, it might be helpful to make the fact more promiment
@traefiker traefiker merged commit e0f265d into traefik:v2.0 Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants