CloseNotifier: return pointer instead of value #6010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In bdf4c67, we added CloseNotify specific versions of the responseWriter wrappers in accesslog and metrics. But the implementer is the pointer, not the value, and we messed up because we returned the value instead of the pointer in the "constructor". Also, we had forgotten to remove the CloseNotify method for the type that is not supposed to implement it. Therefore this PR fixes the above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In #5985, we added
CloseNotifyspecific versions of theresponseWriterwrappers inaccesslog and metrics.
But the implementer is the pointer, not the value, and we messed up because we returned the value instead of the pointer in the "constructor".
Also, we had forgotten to remove the
CloseNotifymethod for the type that is not supposed to implement it.Therefore this PR fixes the above.
Motivation
Fixes #6008
More
[ ] Added/updated documentation