Skip to content

Use consistent name in ACME documentation #6019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
traefiker merged 1 commit into from
Dec 13, 2019
Merged

Use consistent name in ACME documentation #6019

traefiker merged 1 commit into from
Dec 13, 2019

Conversation

@ldez
Copy link
Contributor

@ldez ldez commented Dec 12, 2019

What does this PR do?

Use consistent name in ACME documentation

Motivation

Fixes #6018

More

  • [ ] Added/updated tests
  • Added/updated documentation

@traefiker traefiker added this to the 2.1 milestone Dec 12, 2019
dtomcej
dtomcej approved these changes Dec 12, 2019
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

SantoDE
SantoDE approved these changes Dec 12, 2019
View reviewed changes
Copy link
Collaborator

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

mmatur
mmatur approved these changes Dec 13, 2019
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 7dcee38 into traefik:v2.1 Dec 13, 2019
@traefiker traefiker mentioned this pull request Dec 13, 2019
Closed
@ldez ldez deleted the chore/doc-acme branch December 17, 2019 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SantoDE SantoDE SantoDE approved these changes

@mmatur mmatur mmatur approved these changes

+1 more reviewer

@dtomcej dtomcej dtomcej approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/acme area/documentation kind/enhancement a new or improved feature. size/S

Projects

None yet

Milestone

2.1

Development

Successfully merging this pull request may close these issues.

5 participants

@ldez @SantoDE @mmatur @dtomcej @traefiker