fix statsd scale for duration based metrics #6054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
kind/bug/fix
mpl
requested changes
Dec 18, 2019
mpl
requested changes
Jan 9, 2020
This comment has been minimized.
This comment has been minimized.
ddtmachado
force-pushed
the
GH-5944-statsd
branch
from
b4c5a60 to
2e07980
Compare
ddtmachado
force-pushed
the
GH-5944-statsd
branch
from
2e07980 to
02bfa0e
Compare
mpl
reviewed
Jan 28, 2020
mpl
reviewed
Feb 25, 2020
ddtmachado
force-pushed
the
GH-5944-statsd
branch
from
164697f to
2f84900
Compare
mpl
requested changes
Feb 28, 2020
Collaborator
mpl
left a comment
mpl
left a comment
There was a problem hiding this comment.
It looks like you forgot to fix something related in the tests: SimpleSuite.TestMetricsPrometheusDefaultEntryPoint is panicking, according to Travis CI.
mpl
approved these changes
Mar 5, 2020
traefiker
force-pushed
the
GH-5944-statsd
branch
from
5115ede to
5d8bcb0
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #5944
Motivation
StatsD assumes that duration based metric values are in Milliseconds.
Currently Traefik always calls the
Observefunction converting thetime.Durationto seconds. With this change we can set the scale in the metric provider implementation, on statsD case Milliseconds, while keeping the current value as the default for those that don't specify it.More
Added/updated documentationAdditional Notes