Skip to content

Add missing certResolver in IngressRoute examples. #6265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
traefiker merged 1 commit into from
Feb 3, 2020
Merged

Add missing certResolver in IngressRoute examples. #6265

traefiker merged 1 commit into from
Feb 3, 2020

Conversation

@ldez
Copy link
Contributor

@ldez ldez commented Feb 2, 2020

What does this PR do?

Adds missing certResolver in IngressRoute examples.

Motivation

Have a better documentation

More

  • Added/updated tests
  • Added/updated documentation

@traefiker traefiker added this to the 2.1 milestone Feb 2, 2020
juliens
juliens approved these changes Feb 3, 2020
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jbdoumenjou
jbdoumenjou approved these changes Feb 3, 2020
View reviewed changes
Copy link
Collaborator

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dtomcej
dtomcej approved these changes Feb 3, 2020
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

@traefiker traefiker merged commit eb2028e into traefik:v2.1 Feb 3, 2020
@ldez ldez deleted the fix/k8s-acme-doc branch February 3, 2020 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliens juliens juliens approved these changes

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

+1 more reviewer

@dtomcej dtomcej dtomcej approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/acme area/documentation area/provider/k8s/crd size/S

Projects

None yet

Milestone

2.1

Development

Successfully merging this pull request may close these issues.

5 participants

@ldez @juliens @jbdoumenjou @dtomcej @traefiker