Merged
Conversation
ldez
added
kind/enhancement
ldez
force-pushed
the
feat/neutral-domains
branch
2 times, most recently
from
359fc1a to
6926a25
Compare
mpl
approved these changes
Mar 13, 2020
ldez
added
bot/light-review
traefiker
force-pushed
the
feat/neutral-domains
branch
from
6926a25 to
c2298c0
Compare
traefiker
removed
bot/light-review
Contributor
|
Fwiw, this change corrupted a number of the examples. The spirit of the change is absolutely desirable, but the examples had more problems (including But, ignoring the fact that a search and replace of bad content results in bad content, a search and replace of cert content that doesn't fix up the encoded form is problematic. |
Closed
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use only the reserved example second level domain names in the documentation.
https://tools.ietf.org/html/rfc2606#section-3
Motivation
Have a better documentation.
Fixes #6470
More
[ ] Added/updated testsAdditional Notes