Fix statement about lego _FILE env var #6964
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solvaholic
commented
Jun 25, 2020
SantoDE
added
area/documentation
status/2-needs-review
and removed
status/0-needs-triage
labels
traefiker
added
bot/merge-retry-1
status/4-merge-in-progress
and removed
bot/merge-retry-1
labels
Lego does not support the `_FILE` variables for everything. For example: > AWS_ACCESS_KEY_ID Managed by the AWS client (AWS_ACCESS_KEY_ID_FILE is not supported) https://go-acme.github.io/lego/dns/route53/
Co-authored-by: Roger D. Winans <solvaholic@users.noreply.github.com>
Contributor
Author
|
Woohoo! Thanks y'all 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lego does not support the
_FILEvariables for everything. For example:https://go-acme.github.io/lego/dns/route53/
What does this PR do?
Fix statement about lego _FILE env var: s/Every/Many/ and instruct reader to follow linked documentation.
Motivation
I trusted the "every" in this doc so thoroughly I failed completely to notice the contradictory statement in lego's doc. I wasted most of a day chasing around
route53: NoCredentialProviders. I disliked that, and I want future readers to have a better experience.More
Additional Notes
Traefik is amazing and I love the work y'all are doing!
I suspect the lack of support for
AWS_ACCESS_KEY_ID_FILEhas more to do with the AWS SDK than with lego or Traefik.