Skip to content

Fix domain fronting #7064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
traefiker merged 4 commits into from
Jul 17, 2020
Merged

Fix domain fronting #7064

traefiker merged 4 commits into from
Jul 17, 2020

Conversation

@juliens
Copy link
Member

@juliens juliens commented Jul 17, 2020

What does this PR do?

Implement a fix for the domain fronting problem.

Motivation

Fix a CVE.
Related to #7039

More

  • Added/updated tests
  • Added/updated documentation

Co-authored-by: Ludovic Fernandez ldez@users.noreply.github.com

@traefiker traefiker added this to the 2.2 milestone Jul 17, 2020
rtribotte
rtribotte approved these changes Jul 17, 2020
View reviewed changes
Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

jbdoumenjou
jbdoumenjou approved these changes Jul 17, 2020
View reviewed changes
Copy link
Collaborator

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ldez
ldez approved these changes Jul 17, 2020
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 0b7aaa3 into traefik:v2.2 Jul 17, 2020
@ldez ldez mentioned this pull request Jul 18, 2020
Closed
@juliens juliens deleted the fix-tls-sni branch April 23, 2021 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

@rtribotte rtribotte rtribotte approved these changes

+1 more reviewer

@ldez ldez ldez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/tls kind/bug/fix a bug fix size/M

Projects

None yet

Milestone

2.2

Development

Successfully merging this pull request may close these issues.

5 participants

@juliens @jbdoumenjou @ldez @rtribotte @traefiker