Fix networkMap construction in ListServices#724
Merged
emilevauge merged 1 commit intotraefik:v1.1from Oct 10, 2016
vincentlepot:fix_network_label_service
Merged
Fix networkMap construction in ListServices#724emilevauge merged 1 commit intotraefik:v1.1from vincentlepot:fix_network_label_service
emilevauge merged 1 commit intotraefik:v1.1from
vincentlepot:fix_network_label_service
Conversation
Contributor
|
@vincentlepot could you rebase on the |
Author
|
Rebase done |
vdemeester
approved these changes
Oct 7, 2016
Contributor
vdemeester
left a comment
vdemeester
left a comment
There was a problem hiding this comment.
LGTM 🐸
/cc @containous/traefik
emilevauge
approved these changes
Oct 10, 2016
Member
emilevauge
left a comment
emilevauge
left a comment
There was a problem hiding this comment.
Thanks @vincentlepot :)
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #719
The problem is due to a moving pointer reference. The networkMap lists network IDs all with the same network information.