Skip to content

fix: pilot metrics unit for req duration. #7309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
traefiker merged 1 commit into from
Sep 18, 2020
Merged

fix: pilot metrics unit for req duration. #7309

traefiker merged 1 commit into from
Sep 18, 2020

Conversation

@ldez
Copy link
Contributor

@ldez ldez commented Sep 18, 2020

What does this PR do?

pilot metrics unit for req duration.

Motivation

use ms instead of s

More

  • Added/updated tests
  • Added/updated documentation

@ldez ldez added status/2-needs-review kind/bug/fix a bug fix bot/light-review decreases the number of required LGTM from 3 to 1. area/pilot labels Sep 18, 2020
@ldez ldez added this to the 2.3 milestone Sep 18, 2020
mmatur
mmatur approved these changes Sep 18, 2020
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 7e482e9 into traefik:v2.3 Sep 18, 2020
@traefiker traefiker removed bot/light-review decreases the number of required LGTM from 3 to 1. status/3-needs-merge labels Sep 18, 2020
@ldez ldez deleted the fix/pilot-metrics branch September 18, 2020 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mmatur mmatur mmatur approved these changes

Assignees

No one assigned

Labels

area/pilot kind/bug/fix a bug fix size/S

Projects

None yet

Milestone

2.3

Development

Successfully merging this pull request may close these issues.

3 participants

@ldez @mmatur @traefiker