Skip to content

Clarify time-based field units#7447

Merged
traefiker merged 2 commits into
traefik:v2.3from
tomtastic:issue4402b
Oct 22, 2020
Merged

Clarify time-based field units#7447
traefiker merged 2 commits into
traefik:v2.3from
tomtastic:issue4402b

Conversation

@tomtastic
Copy link
Copy Markdown
Contributor

@tomtastic tomtastic commented Oct 21, 2020

What does this PR do?

Clarifies the access-logs documentation for;

  • the minDuration filter units
  • the OriginDuration and Overhead time-based field value units.

Motivation

"Enhancing clarity is always a good thing..." - geraldcroes

Contributing in some small way to the hackathon.

Related to #4402

More

  • Added/updated tests
  • Added/updated documentation

@tomtastic tomtastic changed the base branch from master to v2.3 October 21, 2020 18:44
@ldez ldez added this to the 2.3 milestone Oct 21, 2020
@ldez ldez added the area/logs label Oct 21, 2020
Copy link
Copy Markdown
Collaborator

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Comment thread docs/content/observability/access-logs.md Outdated
Co-authored-by: Romain <rtribotte@users.noreply.github.com>
Copy link
Copy Markdown
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Copy Markdown
Collaborator

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants