Upgrade Ingress Handling to work with networkingv1/Ingress #7549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SantoDE
force-pushed
the
upgrade_ingress_fetching
branch
from
9055811 to
d7b2c0b
Compare
SantoDE
force-pushed
the
upgrade_ingress_fetching
branch
3 times, most recently
from
ae0c7d0 to
cb4ae72
Compare
SantoDE
force-pushed
the
upgrade_ingress_fetching
branch
from
1a0ea48 to
924be46
Compare
rtribotte
reviewed
Dec 29, 2020
rtribotte
reviewed
Dec 29, 2020
rtribotte
reviewed
Dec 29, 2020
rtribotte
reviewed
Dec 29, 2020
SantoDE
force-pushed
the
upgrade_ingress_fetching
branch
2 times, most recently
from
1b6b59f to
5b03bdd
Compare
rtribotte
reviewed
Mar 3, 2021
Member
rtribotte
left a comment
rtribotte
left a comment
There was a problem hiding this comment.
A few typos in test fixtures and a duplicated code portion.
pkg/provider/kubernetes/ingress/fixtures/v19-Ingress-with-exact-pathType_service.yml
Outdated
Show resolved
Hide resolved
pkg/provider/kubernetes/ingress/fixtures/v19-Ingress-with-empty-pathType_service.yml
Outdated
Show resolved
Hide resolved
pkg/provider/kubernetes/ingress/fixtures/v19-Ingress-with-prefix-pathType_service.yml
Outdated
Show resolved
Hide resolved
pkg/provider/kubernetes/ingress/fixtures/v19-Ingress-with-no-pathType_service.yml
Outdated
Show resolved
Hide resolved
pkg/provider/kubernetes/ingress/fixtures/v19-Ingress-with-named-port_service.yml
Outdated
Show resolved
Hide resolved
pkg/provider/kubernetes/ingress/fixtures/v19-Ingress-with-missing-ingressClass_service.yml
Outdated
Show resolved
Hide resolved
pkg/provider/kubernetes/ingress/fixtures/v19-Ingress-with-ingressClass_service.yml
Outdated
Show resolved
Hide resolved
pkg/provider/kubernetes/ingress/fixtures/v19-Ingress-with-ingress-annotation_service.yml
Outdated
Show resolved
Hide resolved
...der/kubernetes/ingress/fixtures/v19-Ingress-with-implementationSpecific-pathType_service.yml
Outdated
Show resolved
Hide resolved
rtribotte
reviewed
Mar 4, 2021
SantoDE
force-pushed
the
upgrade_ingress_fetching
branch
from
8877ea4 to
1a3e4f7
Compare
ldez
approved these changes
Mar 12, 2021
second wave of test fmt
traefiker
force-pushed
the
upgrade_ingress_fetching
branch
from
869cab0 to
af7d3fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Upgrade the K8s Ingress Provider to use the networkingv1/Ingress type, rather than the old extension type. Also, just start needed informers when needed.
Motivation
Be ready for the future.
More
Additional Notes
We have to upgrade the IngressClass Ressource once as well. We need to decide whether to do that in a seperate PR or just here.
Re #7466