Skip to content

Conversation

@juliens
Copy link
Member

@juliens juliens commented Nov 30, 2020

What does this PR do?

Add comments and create some functions to improve readability and maintainability.

Motivation

Improves readability and maintainability.

More

- [ ] Added/updated tests
- [ ] Added/updated documentation

Additional Notes

Co-authored-by: Ludovic Fernandez ldez@users.noreply.github.com

@juliens juliens added kind/enhancement a new or improved feature. status/2-needs-review labels Nov 30, 2020
@juliens juliens added this to the next milestone Nov 30, 2020
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@kevinpollet kevinpollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@traefiker traefiker merged commit b5db753 into traefik:master Dec 1, 2020
@ldez ldez deleted the refacto branch December 1, 2020 09:14
@ldez ldez changed the title Improve setup readability. Improve setup readability Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement a new or improved feature. size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants