Skip to content

Conversation

@rtribotte
Copy link
Member

@rtribotte rtribotte commented Jan 28, 2021

What does this PR do?

This PR introduces TCP middleware support:

  • Adds TCP Middlewares mechanism
  • Adds IPWhitelist as the first TCP middleware (allowing to check the remote address against a source range)
  • Updates the API to serve TCP middlewares info
  • Updates the WebUI to display TCP middlewares

Motivation

Introduction of the TCP middlewares and fixes #6684

More

  • Added/updated tests
  • Added/updated documentation

Additionnal notes

Remaining TODOs:

  • Write the overview introduction for TCP Middlewares in documentation

@tnelson-doghouse
Copy link

rtribotte: I note that there's an unticked task called "Write the overview introduction for TCP Middlewares in documentation", but that there's a commit called "doc: add TCP middlewares overview and IpWhitelist middleware". Does that mean that you did it, but forgot to tick the task? I ask because this PR is listed as having 2/3 complete tasks.

@rtribotte
Copy link
Member Author

Hi @tnelson-doghouse,

Indeed, this task remains unchecked because the introduction page for TCP middleware in the documentation (docs/content/middlewares/tcp/overview.md) needs a proper introduction, and perhaps an illustration too.

@electrical
Copy link

I'm curious as what is holding this back from being merged? This functionality and the original use case is exactly what i'm looking for :-)
Thanks.

@rtribotte
Copy link
Member Author

Hello @electrical,

Thanks for your interest in Traefik!

This PR is labeled as needs-design-review, as you can see in our contribution guide, this means that we have to take a closer look at the scope of impact for that PR to see, how it would interact with the other parts of Traefik.

@Secursus
Copy link

Secursus commented Apr 9, 2021

HI,

I'm looking forward to this PR...

it is still up to date ?

@cma1kep
Copy link

cma1kep commented Apr 9, 2021

Hello,

any changes in Review?

Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

@ldez ldez force-pushed the tcp-middlewares branch from eb84b33 to 64677e3 Compare June 11, 2021 12:50
@ldez ldez removed the bot/no-merge label Jun 11, 2021
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit fc9f41b into traefik:master Jun 11, 2021
@rtribotte rtribotte deleted the tcp-middlewares branch February 14, 2022 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] middlewares for tcp routers