-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Add TCP Middlewares support #7813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
af831c7 to
d934370
Compare
|
rtribotte: I note that there's an unticked task called "Write the overview introduction for TCP Middlewares in documentation", but that there's a commit called "doc: add TCP middlewares overview and IpWhitelist middleware". Does that mean that you did it, but forgot to tick the task? I ask because this PR is listed as having 2/3 complete tasks. |
|
Indeed, this task remains unchecked because the introduction page for TCP middleware in the documentation ( |
|
I'm curious as what is holding this back from being merged? This functionality and the original use case is exactly what i'm looking for :-) |
|
Hello @electrical, Thanks for your interest in Traefik! This PR is labeled as |
|
HI, I'm looking forward to this PR... it is still up to date ? |
|
Hello, any changes in Review? |
42fc6da to
aa21ca8
Compare
dtomcej
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
![]()
Co-authored-by: mpl <mathieu.lonjaret@gmail.com>
Co-authored-by: mpl <mathieu.lonjaret@gmail.com>
Co-authored-by: mpl <mathieu.lonjaret@gmail.com>
Co-authored-by: Daniel Tomcej <daniel.tomcej@gmail.com>
ldez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What does this PR do?
This PR introduces TCP middleware support:
Motivation
Introduction of the TCP middlewares and fixes #6684
More
Additionnal notes
Remaining TODOs: