-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Provider documentation fixes #7823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PCM2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
ldez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
kevinpollet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jbdoumenjou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Co-authored-by: Neil McAllister <neil@neilmcallister.com>
Co-authored-by: Neil McAllister <neil@neilmcallister.com>
db9a9b0 to
a7b8862
Compare
What does this PR do?
This PR is a follow-up to #7808 which in much the same way, proposes many fixes to the provider documentation pages.
It introduces multiple grammar, phrasing and formatting improvements to the middleware documentation pages. It seeks to improve consistency and not introduce any changes that would make the pages inconsistent with other ones. It does not change things across all documents, but some changes might come in another PR (like introducing a standard for describing default values for options and whether they are optional or required.)
Among the most frequent changes you will find in this PR:
will do->does)it's->it is)Some of the other notable changes:
Because there are a substantial amount of small changes, this PR is bound to introduce some mistakes, so it should be reviewed carefully.
Motivation
Improve the provider documentation pages and try to improve consistency.
More
Co-authored-by: Nicholas Wiersma nick@wiersma.co.za