Skip to content

Conversation

@jspdown
Copy link
Contributor

@jspdown jspdown commented Feb 1, 2021

What does this PR do?

This PR fixes servers transport not found default@internal.

Motivation

Fixes #7809

More

  • Added/updated tests
  • Added/updated documentation

This fixes the servers transport not found error.
@jspdown jspdown added this to the 2.4 milestone Feb 1, 2021
@jspdown jspdown changed the title fix: start internal provider before file provider Fix servers transport not found Feb 1, 2021
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

Copy link
Collaborator

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

errCh <- aggregator.Provide(cfgCh, pool)
}()

// Make sure the file provider is always called first, followed by the internal provider.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment still true? Would be good to have some justification here also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants