Skip to content

Fix the infinite loop in forwarded header middleware. #7847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
traefiker merged 1 commit into from
Feb 2, 2021
Merged

Fix the infinite loop in forwarded header middleware. #7847

traefiker merged 1 commit into from
Feb 2, 2021

Conversation

@ldez
Copy link
Contributor

@ldez ldez commented Feb 2, 2021

What does this PR do?

fix: infinite loop in forwarded header middleware.

Motivation

Fixes #7845

More

  • Added/updated tests
  • [ ] Added/updated documentation

Additional Notes

Co-authored-by: kevinpollet pollet.kevin@gmail.com

@ldez ldez added this to the 2.4 milestone Feb 2, 2021
jbdoumenjou
jbdoumenjou approved these changes Feb 2, 2021
View reviewed changes
Copy link
Collaborator

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

kevinpollet
kevinpollet approved these changes Feb 2, 2021
View reviewed changes
Copy link
Member

@kevinpollet kevinpollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez added bot/light-review decreases the number of required LGTM from 3 to 1. status/3-needs-merge and removed status/2-needs-review labels Feb 2, 2021
@traefiker traefiker merged commit bf4a578 into traefik:v2.4 Feb 2, 2021
@traefiker traefiker removed bot/light-review decreases the number of required LGTM from 3 to 1. status/3-needs-merge labels Feb 2, 2021
@traefiker traefiker mentioned this pull request Feb 2, 2021
Closed
@ldez ldez deleted the fix/infinite-loop branch February 2, 2021 10:52
@jbdoumenjou jbdoumenjou changed the title fix: infinite loop in forwarded header middleware. Fix the infinite loop in forwarded header middleware. Feb 2, 2021
@ldez ldez mentioned this pull request Feb 2, 2021
Closed
@linuxgemini linuxgemini mentioned this pull request Feb 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevinpollet kevinpollet kevinpollet approved these changes

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

Assignees

No one assigned

Labels

area/middleware kind/bug/fix a bug fix size/M

Projects

None yet

Milestone

2.4

Development

Successfully merging this pull request may close these issues.

4 participants

@ldez @kevinpollet @jbdoumenjou @traefiker