Merged
Conversation
kvncrw
force-pushed
the
error_span_on_5xx_only
branch
from
9aa4f16 to
42b7664
Compare
SantoDE
added
status/2-needs-review
kind/bug/fix
jbdoumenjou
force-pushed
the
error_span_on_5xx_only
branch
from
0eaa1c3 to
5c9d05c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Generates error spans on
5xxerrors rather than>= 400errors.Motivation
A client generating hundreds of 401s every few minutes.
Generating error spans for client-side errors creates a lot of noise on high-volume systems when the problem is not addressable by the server operator.
Most tracers implement similar logic, only generating an error when the response code is 500 or greater. Examples:
https://github.com/opentracing-contrib/go-stdlib/blob/v1.0.0/nethttp/client.go#L191-L193
https://github.com/opentracing-contrib/nginx-opentracing/blob/v0.14.0/opentracing/src/request_tracing.cpp#L64-L67
More
Additional Notes