-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Allow configuration of advertised port for HTTP/3 #8131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello @valerauko, Thank you for your contribution! I see that the address specified with the new option Also since the only need is to configure an alternate port value, I think that the option should be a port value. WDYT? |
|
Yes that's correct, it's only about what address quic-go advertises in the alt-svc header. I'm actually not sure if it's possible (or advisable) to set a different authority there. But for the common use case, definitely it's just a port specified. |
|
@valerauko So if I get you, it's not advisable to advertise a different port. But then, why not solve this issue by choosing a port for Traefik |
|
In the case of the traefik helm chart, the container port (by default 8443 on websecure) is different from the exposed port (443 by default). Without this option, traefik will advertise the incorrect 8443 instead of the exposed 443 it should. |
|
Hello @valerauko, I reworked the PR to only allow the configuration of the port to advertise in the To test it with k3d, here's an example repo: https://github.com/rtribotte/traefik-k8s-http3-example. |
|
I see you made it way stricter with only being able to advertise the port. If you think that's more desirable, I have no objections. |
|
If memory serves me well I had troubles with kubernetes because services backed by AWS ELB do not support both UDP & TCP at the same time on the same port. This means you if you want both HTTP and HTTP3 you shall have 2 different loadbalancers with 2 different IP adresses, one listening on :443/tcp and the other on :443/udp. This means if you want to serve H3 on the same port as HTTP there is a need to advertise H3 on a different IP address. |
|
@sylr We have to confirm that, but yes that would be a limitation. With this PR, if the constraint is having two AWS ELB which cannot be configured on the same port with different protocols, |
juliens
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ldez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
jbdoumenjou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
What does this PR do?
Motivation
#8130
More
Additional Notes
I saw that the Docker integration tests are failing, but I can't figure out what is causing the issue. If someone could provide some feedback I'll fix it...