Fix incorrect behaviour with multi-port endpoint subsets #8156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coufalja
commented
May 26, 2021
Contributor
Author
There was a problem hiding this comment.
I guess that this was a mere oversight, by declaring the variable before the cycle its value remained unchanged in subsequent cycles thus (incorrectly) falling through the if port == 0 guard.
jbdoumenjou
added
kind/bug/fix
traefiker
force-pushed
the
pods-subset-fix
branch
from
2464fe3 to
015208b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes an incorrect behaviour when the Endpoints generated for Service pods contain two distinct subsets for two different ports.
Motivation
The bug had broken down one of our production services for a while and we had to revert to Traefik 1.7.
The bug caused some (third in our case) of HTTP requests to be forwarded to pods that hadn't had the port exposed.
More
Additional Notes