Create buffered signals channel #8190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I am unsure if this is a "bugfix" worthy of being on 2.4, but it is a quick rebase if needed. |
jbdoumenjou
added
kind/enhancement
ldez
added
kind/bug/fix
mmatur
approved these changes
Jun 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Creates a buffered signal channel so that signals don't get dropped.
Motivation
Required to pass newer versions of
go vetMore
[ ] Added/updated testsnot needed[ ] Added/updated documentationnot neededAdditional Notes
Our code looks like the example given:
golang/go#45043 (comment)
The signal documentation suggests using a sufficient sized buffer to handle signal backup in the channel: https://golang.org/pkg/os/signal/#Notify so I figure 100 signals should be more than sufficient.