Skip to content

Check if defaultcertificate is defined in store#8274

Merged
traefiker merged 3 commits intotraefik:v2.4from
dtomcej:issue-8273
Jul 19, 2021
Merged

Check if defaultcertificate is defined in store#8274
traefiker merged 3 commits intotraefik:v2.4from
dtomcej:issue-8273

Conversation

@dtomcej
Copy link
Contributor

@dtomcej dtomcej commented Jul 16, 2021

What does this PR do?

Allows a tls store without a default certificate to be used.

Motivation

Fixes #8273

More

  • Added/updated tests
  • Added/updated documentation - None needed, bugfix

Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 8d4620d into traefik:v2.4 Jul 19, 2021
@ldez ldez mentioned this pull request Jul 23, 2021
2 tasks
@jbdoumenjou jbdoumenjou changed the title check if defaultcertificate is defined in store Check if defaultcertificate is defined in store Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants