Get Kubernetes server version early #8286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtribotte
added
status/2-needs-review
area/provider/k8s/ingress
kind/bug/fix
mpl
approved these changes
Jul 20, 2021
traefiker
removed
bot/light-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR refactor changes from PR #8185.
It allows failing early if the server version cannot be fetched.
It also changes the return of the
WatchAllmethod in case of error when fetching the server version, in which case, the event chan returned would be nil.As per this modification, a change in the unit tests of the client allows setting a valid version in the fake client to avoid this error case.
Motivation
Re-introduce fixes that were lost during a rebase in PR #8185.
More
Added/updated documentationAdditional Notes
It is also more compliant with further changes on the Ingress provider on branch v2.5.