Bump go.elastic.co/apm version to v1.13.1 #8399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtribotte
added
status/2-needs-review
kind/bug/fix
mpl
approved these changes
Aug 31, 2021
traefiker
force-pushed
the
bump-elastic-apm-to-v1.13.1
branch
from
62e2ee5 to
07dfd14
Compare
This was referenced Sep 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR bumps
go.elastic.co/apmversion from v1.11.0 to v1.13.1:Motivation
This bump brings a fix for issue #8158.
The fix elastic/apm-agent-go#931 (release v1.12.0) allows spans without "context.destination.service.name" value (elastic/apm#180) to be validated by APM server.
It will prevent request validation errors as the following:
fixes #8158
More
Added/updated testsAdded/updated documentationAdditional Notes
While this PR prevents seeing validation errors in Traefik logs, it seems that the validation error wasn't preventing the APM server to accept the spans.