Fix Prometheus router's metrics #8425
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR intends to solve 2 issues in the metrics exports on routers:
The first is when you try to export more than once the metrics of a router. The first time, it exports the correct value, and the second time, metrics are not exported.
Metrics are not exported the second time
The second issue is related to the
isOutdatedmethod on the Prometheus exporter:The exporter did not check if routers were still up-to-date, and if old routers needed to be removed from Prometheus metrics.
Motivation
Solve Prometheus metrics issues:
More
Added/updated documentationCo-authored-by: Michael michael.matur@gmail.com
Co-authored-by: Romain rtribotte@users.noreply.github.com