Ensure disableHTTP2 works with k8s crd#8448
Merged
traefiker merged 2 commits intotraefik:v2.5from Sep 16, 2021
Merged
Conversation
jbdoumenjou
added
kind/bug/fix
jbdoumenjou
force-pushed
the
ensure_disablehttp2_works_on_k8s
branch
from
a82198e to
c4d0497
Compare
kevinpollet
approved these changes
Sep 16, 2021
traefiker
force-pushed
the
ensure_disablehttp2_works_on_k8s
branch
from
c4d0497 to
c41d3f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR ensures that disabling http2 works when using the kubernetes
ServersTransportCRD. I have added a test verifying that it works now. Previously setting thedisableHTTP2field in the CRD did not change that configuration option.Motivation
We host traefik as an ingress loadbalancer for a number of application servers running on k8s that do not support http2 - when trying to disable http2 we kept seeing errors on our application servers indicating that http2 had not been disabled.
More
Additional Notes
From my review of the code when implementing this change it looks like the
PeerCertURIoption in the CRD is also not being translated into a proper configuration of traefik. However I have not functionally verified this as we do not utilize this feature.