Skip to content

Conversation

@FoseFx
Copy link
Contributor

@FoseFx FoseFx commented Sep 21, 2021

What does this PR do?

In /routing/providers/kubernetes-crd.md links to the docs of an ExternalName Service were pointing to the French translation. This PR replaces those with the English version of them.

Motivation

I don't speak French.
Changing the language will remove the hash, so you need to find the ExternalName Section manually, which is annoying.

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

Copy link
Member

@kevinpollet kevinpollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

Copy link
Collaborator

@tomMoulard tomMoulard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌 🇫🇷

Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

Copy link
Collaborator

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants